linux-kernel - Re: [PATCH v3] nvmet-auth: update sc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <i3hfkgxavqcpodqshi6iekpyyqsdndiwpgp7pp2el5v4liznsl@xntdmhnujfur>
Date: Sun, 16 Nov 2025 23:53:59 +0000
From: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To: "alistair23@...il.com" <alistair23@...il.com>
CC: "hare@...e.de" <hare@...e.de>, "kbusch@...nel.org" <kbusch@...nel.org>,
	"axboe@...nel.dk" <axboe@...nel.dk>, hch <hch@....de>, "sagi@...mberg.me"
	<sagi@...mberg.me>, "kch@...dia.com" <kch@...dia.com>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Alistair
 Francis <Alistair.Francis@....com>
Subject: Re: [PATCH v3] nvmet-auth: update sc_c in target host hash
 calculation

On Nov 07, 2025 / 09:17, alistair23@...il.com wrote:
> From: Alistair Francis <alistair.francis@....com>
> 
> Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added
> the sc_c variable to the dhchap queue context structure which is
> appropriately set during negotiate and then used in the host response.
> 
> This breaks secure concat connections with a Linux target as the target
> code wasn't updated at the same time. This patch fixes this by adding a
> new sc_c variable to the host hash calculations.
> 
> Fixes: 7e091add9c43 ("nvme-auth: update sc_c in host response")
> Signed-off-by: Alistair Francis <alistair.francis@....com>

I confirmed that this patch avoids the blktests nvme/063 failure symptom
that I reported [*]. Thanks for the fix.

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>

[*] https://lore.kernel.org/linux-nvme/6xoxbezgcnv4bfaevi3pdpesfelia3epxiddk47azho7y5mnhr@ykmlqgnrbl3w/