linux-kernel - Re: [PATCH v2] HID: memory leak in dualshock4_get_calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddb16ea8-7588-4c0a-9e34-6bd8babd598f@enpas.org>
Date: Sun, 16 Nov 2025 13:34:50 +0900
From: Max Staudt <max@...as.org>
To: Eslam Khafagy <eslam.medhat1993@...il.com>,
 roderick.colenbrander@...y.com, jikos@...nel.org, bentiss@...nel.org
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, syzbot+4f5f81e1456a1f645bf8@...kaller.appspotmail.com
Subject: Re: [PATCH v2] HID: memory leak in dualshock4_get_calibration_data

On 11/16/25 11:27 AM, Eslam Khafagy wrote:
> function dualshock4_get_calibration_data allocates memory to pointer
> buf. however the function may exit prematurely due to transfer_failure
> in this case it does not handle freeing memory.
> 
> this patch handles memory deallocation at exit.

Reviewed-by: Max Staudt <max@...as.org>


One minor thing that I forgot: I see that the commit message is all 
lower case. Proper capitalisation helps readability and matches the 
kernel style. No need to resend this time, but in case you're sending a 
v3 for any other reason, it'd be great if you picked this up as well :)


Thanks for your patch!

Max