linux-kernel - Re: [PATCH v8 1/1] smb: move FILE_SYSTEM_ATTRIBUTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0219f68e-32f6-4511-9ccc-698b77ea12de@linux.dev>
Date: Mon, 17 Nov 2025 08:08:56 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org,
 christophe.jaillet@...adoo.fr, linux-cifs@...r.kernel.org,
 linux-kernel@...r.kernel.org, chenxiaosong@...nxiaosong.com,
 ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v8 1/1] smb: move FILE_SYSTEM_ATTRIBUTE_INFO to
 common/fscc.h

And in the following part of the SMB2_QFS_attr() function, it also seems 
that we should change it to `memcpy(..., min_t(..., min_len))`.

```c
SMB2_QFS_attr()
{
...
	if (level == FS_ATTRIBUTE_INFORMATION)
	        memcpy(&tcon->fsAttrInfo, offset
	                + (char *)rsp, min_t(unsigned int,
	                rsp_len, max_len));
...
}
```

Thanks,
ChenXiaoSong.

On 11/17/25 7:47 AM, ChenXiaoSong wrote:
> Yes, we should also add MAX_FS_NAME_LEN here. This was my mistake.
> 
> Thanks,
> ChenXiaoSong.
> 
> On 11/17/25 7:00 AM, Namjae Jeon wrote:
>> On Sun, Nov 16, 2025 at 3:53 PM <chenxiaosong.chenxiaosong@...ux.dev> 
>> wrote:
>>>
>>> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>>>
>>> Modify the following places:
>>>
>>>    - struct filesystem_attribute_info -> FILE_SYSTEM_ATTRIBUTE_INFO
>>>    - Remove MIN_FS_ATTR_INFO_SIZE definition
>>>    - Introduce MAX_FS_NAME_LEN
>>>    - max_len of FileFsAttributeInformation -> 
>>> sizeof(FILE_SYSTEM_ATTRIBUTE_INFO) + MAX_FS_NAME_LEN
>>>    - min_len of FileFsAttributeInformation -> 
>>> sizeof(FILE_SYSTEM_ATTRIBUTE_INFO)
>>>
>>> Then move FILE_SYSTEM_ATTRIBUTE_INFO to common header file.
>>>
>>> Suggested-by: Namjae Jeon <linkinjeon@...nel.org>
>>> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
>>
>> Did you check if it is being used here too?
>> cifssmb.c:4866:        sizeof(FILE_SYSTEM_ATTRIBUTE_INFO));
>