linux-kernel - Re: [PATCH v1 1/1] nfsd: Mark variable __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176338731878.4204.10224670039692915729.b4-ty@oracle.com>
Date: Mon, 17 Nov 2025 08:49:29 -0500
From: Chuck Lever <cel@...nel.org>
To: linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	Jeff Layton <jlayton@...nel.org>,
	NeilBrown <neil@...wn.name>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] nfsd: Mark variable __maybe_unused to avoid W=1 build break

From: Chuck Lever <chuck.lever@...cle.com>

On Thu, 13 Nov 2025 09:31:31 +0100, Andy Shevchenko wrote:
> Clang is not happy about set but (in some cases) unused variable:
> 
> fs/nfsd/export.c:1027:17: error: variable 'inode' set but not used [-Werror,-Wunused-but-set-variable]
> 
> since it's used as a parameter to dprintk() which might be configured
> a no-op. To avoid uglifying code with the specific ifdeffery just mark
> the variable __maybe_unused.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: Mark variable __maybe_unused to avoid W=1 build break
      commit: 56e9f88b25abf08de6f2b1bfbbb2ddc4e6622d1e

--
Chuck Lever