linux-kernel - Re: [PATCH] drm/kmb: Fix error handling in kmb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1822671a-5f10-43b1-b678-04f47752cd29@web.de>
Date: Mon, 17 Nov 2025 16:18:01 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, dri-devel@...ts.freedesktop.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Anitha Chrisanthus <anitha.chrisanthus@...el.com>,
 David Airlie <airlied@...il.com>, Edmund Dea <edmund.j.dea@...el.com>,
 Sam Ravnborg <sam@...nborg.org>, Simona Vetter <simona@...ll.ch>
Subject: Re: [PATCH] drm/kmb: Fix error handling in kmb_probe

…
> Add put_device() in all code paths where dsi_pdev is no longer needed,
> including error paths and the normal removal path.

How do you think about to apply the attribute “__free(put_device)”?
https://elixir.bootlin.com/linux/v6.18-rc5/source/include/linux/device.h#L1183

By the way:
I propose to avoid duplicate of_node_put() calls in this function implementation.

Would it be helpful to append parentheses to the function name in the summary phrase?

Regards,
Markus