linux-kernel - Re: [PATCH] iommu/omap: Fix error handling in omap_iommu_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ccf660b-9bbe-4f2f-8237-295f6d6f70f9@web.de>
Date: Mon, 17 Nov 2025 16:46:11 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: make24@...as.ac.cn, iommu@...ts.linux.dev
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>, Jörg Rödel
 <joro@...tes.org>, Robin Murphy <robin.murphy@....com>,
 Suman Anna <s-anna@...com>, Tero Kristo <t-kristo@...com>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH] iommu/omap: Fix error handling in omap_iommu_probe_device

> omap_iommu_probe_device() calls of_find_device_by_node() which
> increments the reference count of the platform device, but fails to
> decrement the reference count in both success and error paths. This
> could lead to resource leakage and prevent proper device cleanup when
> the IOMMU is unbound or the device is removed.

1. See also once more:
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc5#n94

2. May the statement “ret = -EINVAL;” be moved behind an additional label?

3. Would it be helpful to append parentheses to the function name in the summary phrase?


Regards,
Markus