linux-kernel - Re: [PATCH] nfsd: fix memory leak in nfsd_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176339614007.12979.15536474028205578081.b4-ty@oracle.com>
Date: Mon, 17 Nov 2025 11:15:46 -0500
From: Chuck Lever <cel@...nel.org>
To: shardulsb08@...il.com,
	Shardul Bankar <shardul.b@...ricsoftware.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+099461f8558eb0a1f4f3@...kaller.appspotmail.com,
	jlayton@...nel.org,
	neil@...wn.name,
	okorniev@...hat.com,
	Dai.Ngo@...cle.com,
	tom@...pey.com,
	janak@...ricsoftware.com
Subject: Re: [PATCH] nfsd: fix memory leak in nfsd_create_serv error paths

From: Chuck Lever <chuck.lever@...cle.com>

On Mon, 17 Nov 2025 17:41:21 +0530, Shardul Bankar wrote:
> When nfsd_create_serv() calls percpu_ref_init() to initialize
> nn->nfsd_net_ref, it allocates both a percpu reference counter
> and a percpu_ref_data structure (64 bytes). However, if the
> function fails later due to svc_create_pooled() returning NULL
> or svc_bind() returning an error, these allocations are not
> cleaned up, resulting in a memory leak.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: fix memory leak in nfsd_create_serv error paths
      commit: d0ce35d0a4fe945e72b57be84d6e4e59c28e87d3

--
Chuck Lever