linux-kernel - Re: [PATCH v4 1/3] tracing: Have tracer option be instance specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251117113201.46983cbb@gandalf.local.home>
Date: Mon, 17 Nov 2025 11:32:01 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Steven Rostedt <rostedt@...nel.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v4 1/3] tracing: Have tracer option be instance specific

On Mon, 17 Nov 2025 17:03:37 +0100
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> > @@ -5152,12 +5180,14 @@ static int tracing_trace_options_show(struct seq_file *m, void *v)
> >  			seq_printf(m, "no%s\n", trace_options[i]);
> >  	}
> >  
> > -	trace = tr->current_trace;
> > -	if (!trace->flags || !trace->flags->opts)
> > +	flags = tr->current_trace_flags;
> > +	if (!flags || !flags->opts)
> >  		return 0;
> >  
> > -	tracer_flags = tr->current_trace->flags->val;
> > -	trace_opts = tr->current_trace->flags->opts;  
> 
> > +	trace = tr->current_trace;  
> 
> Removing it and this line fixes, but I'm not sure that's correct one, so feel
> free to fold the change or if it will be a fix,
> Reported-by: Andy Shevchenko <andriy.shevchenko@...el.com>

Thanks for the report. Yeah, that variable is no longer used and can be
removed. I'll send a patch.

-- Steve


> 
> > +	tracer_flags = flags->val;
> > +	trace_opts = flags->opts;