linux-kernel - Re: [PATCH] UFS: Make TM command timeout configurable from host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3dcb711-990d-4e4e-a128-8a0cd0ce8886@acm.org>
Date: Mon, 17 Nov 2025 08:43:04 -0800
From: Bart Van Assche <bvanassche@....org>
To: Seunghui Lee <sh043.lee@...sung.com>,
 'Peter Wang (王信友)' <peter.wang@...iatek.com>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 martin.petersen@...cle.com
Subject: Re: [PATCH] UFS: Make TM command timeout configurable from host side

On 11/16/25 11:11 PM, Seunghui Lee wrote:
>   /* maximum number of retries for a general UIC command  */
>   #define UFS_UIC_COMMAND_RETRIES 3
> @@ -7663,7 +7663,7 @@ int ufshcd_try_to_abort_task(struct ufs_hba *hba, int tag)
>          int poll_cnt;
>          u8 resp = 0xF;
>   
> -       for (poll_cnt = 100; poll_cnt; poll_cnt--) {
> +       for (poll_cnt = 30; poll_cnt; poll_cnt--) {
>                  err = ufshcd_issue_tm_cmd(hba, lrbp->lun, lrbp->task_tag,
>                                  UFS_QUERY_TASK, &resp);
>                  if (!err && resp == UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED) {

There are no other SCSI drivers I know of that have a retry loop around
the code that submits task management functions. I propose to reduce the
retry count in this function from 100 to 1.

Thanks,

Bart.