linux-kernel - Re: [patch V4 03/20] sched/mmcid: Cacheline align MM CID storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a3ae12e-1ca7-4c4e-9906-03a6784d321e@efficios.com>
Date: Mon, 17 Nov 2025 11:44:49 -0500
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
 Gabriele Monaco <gmonaco@...hat.com>, Michael Jeanson
 <mjeanson@...icios.com>, Jens Axboe <axboe@...nel.dk>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 "Gautham R. Shenoy" <gautham.shenoy@....com>,
 Florian Weimer <fweimer@...hat.com>, Tim Chen <tim.c.chen@...el.com>,
 Yury Norov <yury.norov@...il.com>, Shrikanth Hegde <sshegde@...ux.ibm.com>
Subject: Re: [patch V4 03/20] sched/mmcid: Cacheline align MM CID storage

On 2025-11-16 15:48, Thomas Gleixner wrote:
[...]
> --- a/include/linux/rseq_types.h
> +++ b/include/linux/rseq_types.h
> @@ -112,7 +112,7 @@ struct sched_mm_cid {
>    */
>   struct mm_cid_pcpu {
>   	unsigned int	cid;
> -};
> +}____cacheline_aligned_in_smp;

Missing space between "}" and "____cacheline_aligned_in_smp".

>   
>   /**
>    * struct mm_mm_cid - Storage for per MM CID data
> @@ -126,7 +126,7 @@ struct mm_mm_cid {
>   	struct mm_cid_pcpu	__percpu *pcpu;
>   	unsigned int		nr_cpus_allowed;
>   	raw_spinlock_t		lock;
> -};
> +}____cacheline_aligned_in_smp;

likewise.

Other than those nits:

Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com