linux-kernel - Re: [PATCH v2] spi: bcm63xx: fix premature CS deassertion on RX-only transactions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRtbeo0pFSFQCR9d@sirena.co.uk>
Date: Mon, 17 Nov 2025 17:29:30 +0000
From: Mark Brown <broonie@...nel.org>
To: Hang Zhou <929513338@...com>
Cc: jonas.gorski@...il.com, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: bcm63xx: fix premature CS deassertion on RX-only
 transactions

On Tue, Nov 18, 2025 at 03:53:38AM +1100, Hang Zhou wrote:

> I initially picked 0xFF because in most case, the SPI bus is high when it's idle, but in practice 0x00 works just as well here.

> If you prefer, I'm happy to switch the dummy value to 0x00 for consistency and respin this as v3.

No, it's OK - if this hardware defaults to keeing the signal high then
0xff is a better choice.  Most hardware defaults to keeping the line
low.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)