linux-kernel - Re: [PATCH] platform/x86/intel/speed_select_if: Convert PCIBIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7383cdac5f30f374ee928fdb9b4f5d6e97e93607.camel@linux.intel.com>
Date: Mon, 17 Nov 2025 09:30:09 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Haotian Zhang <vulab@...as.ac.cn>, hansg@...nel.org, 
	ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/intel/speed_select_if: Convert PCIBIOS_*
 return codes to errnos

On Mon, 2025-11-17 at 11:33 +0800, Haotian Zhang wrote:
> isst_if_probe() uses pci_read_config_dword() that returns PCIBIOS_*
> codes. The return code is returned from the probe function as is but
> probe functions should return normal errnos. A proper implementation
> can be found in drivers/leds/leds-ss4200.c.
> 
> Convert PCIBIOS_* return codes using pcibios_err_to_errno() into
> normal errno before returning.
> 
> Fixes: d3a23584294c ("platform/x86: ISST: Add Intel Speed Select mmio
> interface")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c
> b/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c
> index 3f4343147dad..950ede5eab76 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c
> @@ -108,11 +108,11 @@ static int isst_if_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
>  
>  	ret = pci_read_config_dword(pdev, 0xD0, &mmio_base);
>  	if (ret)
> -		return ret;
> +		return pcibios_err_to_errno(ret);
>  
>  	ret = pci_read_config_dword(pdev, 0xFC, &pcu_base);
>  	if (ret)
> -		return ret;
> +		return pcibios_err_to_errno(ret);
>  
>  	pcu_base &= GENMASK(10, 0);
>  	base_addr = (u64)mmio_base << 23 | (u64) pcu_base << 12;