linux-kernel - Re: [RFC 04/10] drivers: i915 selftest: use pgtable_has_pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c745e54-1cb1-44d4-abc3-00e6511cf67c@kernel.org>
Date: Mon, 17 Nov 2025 18:30:13 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Luiz Capitulino <luizcap@...hat.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org
Cc: ryan.roberts@....com, akpm@...ux-foundation.org,
 lorenzo.stoakes@...cle.com
Subject: Re: [RFC 04/10] drivers: i915 selftest: use pgtable_has_pmd_leaves()

On 06.11.25 22:28, Luiz Capitulino wrote:
> igt_can_allocate_thp() uses has_transparente_hugepage() to check if
> PMD-sized pages are supported, use pgtable_has_pmd_leaves() instead.
> 
> Signed-off-by: Luiz Capitulino <luizcap@...hat.com>
> ---
>   drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> index bd08605a1611..c76aafa36d2b 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c
> @@ -1316,7 +1316,7 @@ typedef struct drm_i915_gem_object *
>   
>   static inline bool igt_can_allocate_thp(struct drm_i915_private *i915)
>   {
> -	return i915->mm.gemfs && has_transparent_hugepage();
> +	return i915->mm.gemfs && pgtable_has_pmd_leaves();

On second thought, is it problematic that we might be losing the 
CONFIG_TRANSPARENT_HUGEPAGE check? Should we check for that separately?

-- 
Cheers

David