linux-kernel - Re: [RFC 06/10] mm: debug_vm_pgtable: use pgtable_has_pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c80c776d-182f-4f0e-a974-b9bcbcd394be@kernel.org>
Date: Mon, 17 Nov 2025 18:40:07 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Luiz Capitulino <luizcap@...hat.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org
Cc: ryan.roberts@....com, akpm@...ux-foundation.org,
 lorenzo.stoakes@...cle.com
Subject: Re: [RFC 06/10] mm: debug_vm_pgtable: use pgtable_has_pmd_leaves()

On 06.11.25 22:28, Luiz Capitulino wrote:
> debug_vm_pgtable calls has_transparent_hugepage() in multiple places to
> check if PMD-sized pages are supported, use pgtable_has_pmd_leaves()

Is that code even dealing with pages? Likely we really only want to 
check whether PMD leaves are supported, independent of any pages.

> instead.
> 
> Signed-off-by: Luiz Capitulino <luizcap@...hat.com>
> ---
>   mm/debug_vm_pgtable.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index 830107b6dd08..241b36c78ac9 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -170,7 +170,7 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx)
>   	unsigned long val = idx, *ptr = &val;
>   	pmd_t pmd;
>   
> -	if (!has_transparent_hugepage())
> +	if (!pgtable_has_pmd_leaves())
>   		return;


All of these are currently protected by CONFIG_TRANSPARENT_HUGEPAGE, right?

-- 
Cheers

David