linux-kernel - Re: [net PATCH] octeontx2-af: Skip TM tree print for disabled SQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRtepJO3CiwlG5gO@horms.kernel.org>
Date: Mon, 17 Nov 2025 17:43:00 +0000
From: Simon Horman <horms@...nel.org>
To: Anshumali Gaur <agaur@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sunil Goutham <sgoutham@...vell.com>,
	Linu Cherian <lcherian@...vell.com>,
	Geetha sowjanya <gakula@...vell.com>,
	Jerin Jacob <jerinj@...vell.com>, hariprasad <hkelam@...vell.com>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [net PATCH] octeontx2-af: Skip TM tree print for disabled SQs

On Thu, Nov 13, 2025 at 03:09:00PM +0530, Anshumali Gaur wrote:
> Currently, the TM tree is printing all SQ topology including those
> which are not enabled, this results in redundant output for SQs
> which are not active. This patch adds a check in print_tm_tree()
> to skip printing the TM tree hierarchy if the SQ is not enabled.
> 
> Fixes: b907194a5d5b ("octeontx2-af: Add debugfs support to dump NIX TM topology")
> Signed-off-by: Anshumali Gaur <agaur@...vell.com>

Thanks Anshumali,

I agree that this is a nice change.  But I'd lean towards this being
net-next material rather than a bugfix for net.

This is because my understanding is that the change enhances the
readability of debugfs output which, as the name implies, is for debugging.

...