linux-kernel - Re: [net-next v1] dt-bindings: can: mpfs: document resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251117-edgy-extenuate-6850a9440802@spud>
Date: Mon, 17 Nov 2025 18:41:56 +0000
From: Conor Dooley <conor@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>, devicetree@...r.kernel.org,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol@...nel.org>,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-can@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Daire McNamara <daire.mcnamara@...rochip.com>
Subject: Re: [net-next v1] dt-bindings: can: mpfs: document resets

On Mon, Nov 17, 2025 at 06:29:55PM +0000, Conor Dooley wrote:
> On Mon, Nov 17, 2025 at 12:27:44PM -0600, Rob Herring (Arm) wrote:
> > 
> > On Mon, 17 Nov 2025 16:38:18 +0000, Conor Dooley wrote:
> > > From: Conor Dooley <conor.dooley@...rochip.com>
> > > 
> > > The CAN cores on Polarfire SoC both have a reset. The platform firmware
> > > brings both cores out of reset, but the linux driver must use them
> > > during normal operation. The resets should have been made required, but
> > > this is one of the things that can happen when the binding is written
> > > without driver support.
> > > 
> > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
> > > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> > > ---
> > > This is the second mistake in this binding, both spotted because of the
> > > driver being written (although this one sat downstream for a while for
> > > w/e reason). I wish I could say that I'd send the driver soon, but I am
> > > busy upstreaming things I wrote and therefore understand at the moment,
> > > so a driver that I'd have to go understand and review before sending is
> > > low priority, sorry!
> > > 
> > > CC: Conor Dooley <conor.dooley@...rochip.com>
> > > CC: Daire McNamara <daire.mcnamara@...rochip.com>
> > > CC: Marc Kleine-Budde <mkl@...gutronix.de>
> > > CC: Vincent Mailhol <mailhol@...nel.org>
> > > CC: Rob Herring <robh@...nel.org>
> > > CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> > > CC: linux-riscv@...ts.infradead.org
> > > CC: linux-can@...r.kernel.org
> > > CC: devicetree@...r.kernel.org
> > > CC: linux-kernel@...r.kernel.org
> > > ---
> > >  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml       | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.example.dtb: can@...0c000 (microchip,mpfs-can): 'resets' is a required property
> > 	from schema $id: http://devicetree.org/schemas/net/can/microchip,mpfs-can.yaml
> 
> Two issues in the same branch now, there's something weird going on with
> my test script. /sigh guess that's my evening gone.

I can spend my evening playing poe after all, I am pretty sure this was
caused by running my test script and then immediately switching windows
back and doing a rebase... I'll send a v2 tomorrow or w/e.
pw-bot: changes-requested

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)