linux-kernel - Re: [PATCH 1/2] dt-bindings: frequency: adf4377: add clk provider

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251117-cloning-nickname-16a95d4b0795@spud>
Date: Mon, 17 Nov 2025 19:19:01 +0000
From: Conor Dooley <conor@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: jic23@...nel.org, robh@...nel.org, conor+dt@...nel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: frequency: adf4377: add clk provider

On Fri, Nov 14, 2025 at 11:59:22AM +0000, Antoniu Miclaus wrote:
> Add support for clock provider.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
>  .../bindings/iio/frequency/adi,adf4377.yaml   | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> index 5f950ee9aec7..dab1591a36b3 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml
> @@ -40,6 +40,12 @@ properties:
>      items:
>        - const: ref_in
>  
> +  '#clock-cells':
> +    const: 0
> +
> +  clock-output-names:
> +    maxItems: 1
> +
>    chip-enable-gpios:
>      description:
>        GPIO that controls the Chip Enable Pin.
> @@ -99,4 +105,18 @@ examples:
>              clock-names = "ref_in";
>          };
>      };
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        frequency@0 {
> +            compatible = "adi,adf4378";
> +            reg = <0>;
> +            spi-max-frequency = <10000000>;
> +            clocks = <&adf4378_ref_in>;
> +            clock-names = "ref_in";
> +            #clock-cells = <0>;
> +            clock-output-names = "adf4378_clk";

Why's the point of having "_clk" in a clock name?
Also, not sure you need a new example for this, could just put them in
the other example, no?

Drop the _clk at least, and then
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
pw-bot: changes-requested

> +        };
> +    };
>  ...
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)