linux-kernel - Re: [PATCH 02/10] KVM: emulate: move Src2Shift up one bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ac436ef-f625-415d-952b-a88cfbb43737@intel.com>
Date: Mon, 17 Nov 2025 11:51:51 -0800
From: "Chang S. Bae" <chang.seok.bae@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>, <linux-kernel@...r.kernel.org>,
	<kvm@...r.kernel.org>
CC: <kbusch@...nel.org>
Subject: Re: [PATCH 02/10] KVM: emulate: move Src2Shift up one bit

On 11/13/2025 4:36 PM, Paolo Bonzini wrote:
> An irresistible microoptimization (changing accesses to Src2 to just an
> AND :)) that also frees a bit for AVX in the low flags word.  This makes
> it closer to SSE since both of them can access XMM registers, pointlessly
> shaving another clock cycle or two (maybe).
> 
> No functional change intended.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Yes, this looks sane to me as well:
   Reviewed-by: Chang S. Bae <chang.seok.bae@...el.com