linux-kernel - Re: [PATCH 05/10] KVM: emulate: share common register decoding code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a140a86-59d1-43d1-a841-905721cbfaf7@intel.com>
Date: Mon, 17 Nov 2025 11:55:17 -0800
From: "Chang S. Bae" <chang.seok.bae@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>, <linux-kernel@...r.kernel.org>,
	<kvm@...r.kernel.org>
CC: <kbusch@...nel.org>
Subject: Re: [PATCH 05/10] KVM: emulate: share common register decoding code

On 11/13/2025 4:36 PM, Paolo Bonzini wrote:
> Remove all duplicate handling of register operands, including picking
> the right register class and fetching it, by extracting a new function
> that can be used for both REG and MODRM operands.
> 
> Centralize setting op->orig_val = op->val in fetch_register_operand()
> as well.
> 
> No functional change intended.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Looks like a very nice refactoring to me:

   Reviewed-by: Chang S. Bae <chang.seok.bae@...el.com>