linux-kernel - Re: [PATCH v2 02/18] vfio: selftests: Split run.sh into separate scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALzav=fN5CAn8C0x0SnsB7Fpq6o-CHspPvvL3ctk1U5i5FE40A@mail.gmail.com>
Date: Mon, 17 Nov 2025 13:08:38 -0800
From: David Matlack <dmatlack@...gle.com>
To: Alex Mastro <amastro@...com>
Cc: Alex Williamson <alex.williamson@...hat.com>, Alex Williamson <alex@...zbot.org>, 
	Jason Gunthorpe <jgg@...dia.com>, Josh Hilke <jrhilke@...gle.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	Raghavendra Rao Ananta <rananta@...gle.com>, Vipin Sharma <vipinsh@...gle.com>
Subject: Re: [PATCH v2 02/18] vfio: selftests: Split run.sh into separate scripts

On Mon, Nov 17, 2025 at 11:58 AM Alex Mastro <amastro@...com> wrote:
>
> On Wed, Nov 12, 2025 at 07:22:16PM +0000, David Matlack wrote:
> > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> > index 155b5ecca6a9..e9e5c6dc63b6 100644
> > --- a/tools/testing/selftests/vfio/Makefile
> > +++ b/tools/testing/selftests/vfio/Makefile
> > @@ -3,7 +3,11 @@ TEST_GEN_PROGS += vfio_dma_mapping_test
> >  TEST_GEN_PROGS += vfio_iommufd_setup_test
> >  TEST_GEN_PROGS += vfio_pci_device_test
> >  TEST_GEN_PROGS += vfio_pci_driver_test
> > +
> > +TEST_PROGS_EXTENDED := scripts/cleanup.sh
> > +TEST_PROGS_EXTENDED := scripts/lib.sh
> >  TEST_PROGS_EXTENDED := scripts/run.sh
> > +TEST_PROGS_EXTENDED := scripts/setup.sh
>
> I think these assignments will discard prior assignments. Was += intended?

Yes, thanks for catching that!