linux-kernel - Re: [PATCH] rust: allow `clippy::disallowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da4877d2-65fd-4ad2-ac31-68d55bda7c07@nvidia.com>
Date: Mon, 17 Nov 2025 13:13:12 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Miguel Ojeda <ojeda@...nel.org>
Cc: Benno Lossin <lossin@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, rust-for-linux@...r.kernel.org,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 Rae Moar <raemoar63@...il.com>, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH] rust: allow `clippy::disallowed_names` for doctests

On 11/17/25 1:02 PM, Miguel Ojeda wrote:
> On Mon, Nov 17, 2025 at 9:07 AM Miguel Ojeda <ojeda@...nel.org> wrote:
>>
>> Examples (i.e. doctests) may want to use names such as `foo`, thus the
>> `clippy::disallowed_names` lint gets in the way.
>>
>> Thus allow it for all doctests.
>>
>> In addition, remove it from the existing `expect`s we have in a few
>> doctests.
>>
>> This does not mean that we should stop trying to find good names for
>> our examples, though.
>>
>> Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
>> Link: https://lore.kernel.org/rust-for-linux/aRHSLChi5HYXW4-9@google.com/
>> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> 
> Applied to `rust-next` -- thanks everyone!
> 

Is rust-next a rebasing branch? I was going to request a non-empty commit
body, in order to make it more immediately clear what this does. Something
like:

The current set of disallowed names is inherited from clippy's defaults [1],
which are "foo", "baz", and "quux". This may be extended via .clipy.toml,
which so far has no entries for disallowed names.

thanks,
-- 
John Hubbard