linux-kernel - Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cgc7ghpc5z6cf2j5ikplu7ufcac6hk3nraps5ai2senrl7qsh@hbjcomvspn5b>
Date: Mon, 17 Nov 2025 16:51:22 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Sudarshan Shetty <tessolveupstream@...il.com>
Cc: konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: Add support to validate direct
 DSI

On Tue, Nov 11, 2025 at 04:12:45PM +0530, Sudarshan Shetty wrote:

The subject indicates that you're adding support for validating DSI to
all Qualcomm boards. Rewrite this to be more specific.

> Adds device tree support for the Waveshare 10.1-inch
> MIPI-DSI panel on the QCS615 talos evk platform.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile          |  1 +
>  arch/arm64/boot/dts/qcom/talos-evk-dsi.dts | 43 ++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 282d744acd73..d5a3dd98137d 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -306,6 +306,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-qrd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-qrd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-dsi.dtb
>  x1e001de-devkit-el2-dtbs	:= x1e001de-devkit.dtb x1-el2.dtbo
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb x1e001de-devkit-el2.dtb
>  x1e78100-lenovo-thinkpad-t14s-el2-dtbs	:= x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts
> new file mode 100644
> index 000000000000..8a6dc8b6bf8f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-dsi.dts

This isn't the one and only "EVK with DSI support" board. Please follow
other examples and describe the connected panel as a overlay - and be
specific.

This should likely be talos-evk-waveshare-10.3.dtso - so that one can
support other DSI panels...

> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +/dts-v1/;
> +
> +#include "talos-evk-cb.dtsi"

This file doesn't exist, please make sure you structure your patches
such that we don't have multiple discussions about the same topic in
parallel.

> +
> +&i2c1 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	display_mcu: display-mcu@45 {
> +		compatible = "waveshare,touchscreen-panel-regulator";
> +		reg = <0x45>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		enable-gpio = <&display_mcu 2 GPIO_ACTIVE_HIGH>;
> +	};
> +};
> +
> +&mdss_dsi0 {
> +	vdda-supply = <&vreg_l11a>;
> +	status = "okay";
> +
> +	dsi_panel: dsi-panel@1 {
> +		reg = <1>;
> +		compatible = "waveshare,10.1-dsi-touch-a";
> +		reset-gpio = <&display_mcu 1 GPIO_ACTIVE_HIGH>;

Can you confirm that this actually works?

Based on the Waveshare "example" driver I had to enable pins 0, 1, and 4
to make my 12.3 DSI panel to work on my board, and then pin 9 to make
the Goodix touchpad work.


Speaking of which, I want the touchscreen support added in the same
patch.

Regards,
Bjorn

> +		backlight = <&display_mcu>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&mdss_dsi0_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&mdss_dsi0_out {
> +	remote-endpoint = <&panel_in>;
> +};
> -- 
> 2.34.1
>