linux-kernel - Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6073899-710e-450d-9907-1a7a69a4a87d@acm.org>
Date: Mon, 17 Nov 2025 15:35:53 -0800
From: Bart Van Assche <bvanassche@....org>
To: Yu Kuai <yukuai@...as.com>, axboe@...nel.dk, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: nilay@...ux.ibm.com
Subject: Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for
 async requests

On 11/15/25 7:52 PM, Yu Kuai wrote:
> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf)
> +{
> +	return op_is_sync(opf) && !op_is_write(opf);
> +}

The name of this function suggests that it performs an action while it
only performs a test. Please consider renaming this function into e.g.
blk_mq_is_sync_read(). I think the suggested name reflects much more
clearly what this function does than "blk_mq_sched_sync_request()".

Thanks,

Bart.