linux-kernel - Re: [PATCH] rust: lib: Add necessary unsafes for container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7146fee26e0d24d0998e9a9199d9ef3ba842e0a8.camel@mailbox.org>
Date: Mon, 17 Nov 2025 07:36:36 +0100
From: Philipp Stanner <phasta@...lbox.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Philipp Stanner
	 <phasta@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
 <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
 <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
 <dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Viresh
 Kumar <viresh.kumar@...aro.org>, Tamir Duberstein <tamird@...il.com>,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: lib: Add necessary unsafes for container_of

On Fri, 2025-11-14 at 21:21 +0100, Miguel Ojeda wrote:
> On Fri, Nov 14, 2025 at 3:00 PM Philipp Stanner <phasta@...nel.org> wrote:
> > 
> > Add unsafe blocks to container_of to fix the issue.
> 
> The root issue is that we missed unsafe blocks on the list macros
> because imported declarative macros from another crate do not respect
> `unsafe_op_in_unsafe_fn` (or Edition 2024):
> 
>     https://github.com/rust-lang/rust/issues/112504
> 
> I have added it to our list at:
> 
>     https://github.com/Rust-for-Linux/linux/issues/355
> 
> And tagged it with the Rust for Linux label there.

So shall we in the mean time merge a fix as suggested by Alice, IOW a
version 2 of this patch here?

P.