linux-kernel - Re: [PATCH] ocfs2: validate xattr entry count in ocfs2_xattr_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADhLXY4HLStZcuFuqnqw-Pre-19+kvnPjiyG7pZUrLM3B-eA8Q@mail.gmail.com>
Date: Mon, 17 Nov 2025 12:08:43 +0530
From: Deepanshu Kartikey <kartikey406@...il.com>
To: Heming Zhao <heming.zhao@...e.com>
Cc: mark@...heh.com, jlbec@...lplan.org, joseph.qi@...ux.alibaba.com, 
	ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	syzbot+ab0ad25088673470d2d9@...kaller.appspotmail.com
Subject: Re: [PATCH] ocfs2: validate xattr entry count in ocfs2_xattr_list_entries

Hi Heming,

Thank you for reviewing the patch! I've sent v2, but I used -EFSCORRUPTED
instead of -EFAULT/-ENOMEM. Here's my reasoning:

This code is detecting on-disk filesystem corruption (invalid xh_count
value from disk), not a memory error or allocation failure. Using
-EFSCORRUPTED:

1. Matches the existing error handling in ocfs2_xattr_find_entry() for
   similar xattr corruption detection
2. Provides clearer semantics (corruption vs generic fault)
3. Is specifically designed for filesystem corruption cases

I'm happy to change it to -EFAULT if you still prefer, but wanted to
explain my reasoning. What do you think?

Thanks

Deepanshu