linux-kernel - Re: [PATCH 07/14] fs: return a negative error from generic_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b6e9e65-9128-49e1-834f-8771e21c4231@nvidia.com>
Date: Mon, 17 Nov 2025 07:07:03 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>
CC: Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>, Jan
 Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>, Martin Brandenburg
	<martin@...ibond.com>, Carlos Maiolino <cem@...nel.org>, Stefan Roesch
	<shr@...com>, Jeff Layton <jlayton@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"gfs2@...ts.linux.dev" <gfs2@...ts.linux.dev>, "io-uring@...r.kernel.org"
	<io-uring@...r.kernel.org>, "devel@...ts.orangefs.org"
	<devel@...ts.orangefs.org>, "linux-unionfs@...r.kernel.org"
	<linux-unionfs@...r.kernel.org>, "linux-mtd@...ts.infradead.org"
	<linux-mtd@...ts.infradead.org>, "linux-xfs@...r.kernel.org"
	<linux-xfs@...r.kernel.org>, "linux-nfs@...r.kernel.org"
	<linux-nfs@...r.kernel.org>
Subject: Re: [PATCH 07/14] fs: return a negative error from
 generic_update_time

On 11/13/25 22:26, Christoph Hellwig wrote:
> Now that no caller looks at the updated flags, switch generic_update_time
> to the same calling convention as the ->update_time method and return 0
> or a negative errno.
>
> This prepares for adding non-blocking timestamp updates that could return
> -EAGAIN.
>
> Signed-off-by: Christoph Hellwig<hch@....de>
> ---
>   fs/gfs2/inode.c    | 3 +--
>   fs/inode.c         | 6 +++---
>   fs/ubifs/file.c    | 6 ++----
>   fs/xfs/xfs_iops.c  | 6 ++----
>   include/linux/fs.h | 2 +-
>   5 files changed, 9 insertions(+), 14 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 8a7ed80d9f2d..601c14a3ac77 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -2242,8 +2242,7 @@ static int gfs2_update_time(struct inode *inode, int flags)
>   		if (error)
>   			return error;
>   	}
> -	generic_update_time(inode, flags);
> -	return 0;
> +	return generic_update_time(inode, flags);
>   }
>   
>   static const struct inode_operations gfs2_file_iops = {
> diff --git a/fs/inode.c b/fs/inode.c
> index d3edcc5baec9..74e672dd90aa 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -2091,7 +2091,7 @@ EXPORT_SYMBOL(inode_update_timestamps);
>    * or S_VERSION need to be updated we attempt to update all three of them. S_ATIME
>    * updates can be handled done independently of the rest.
>    *
> - * Returns a S_* mask indicating which fields were updated.
> + * Returns a negative error value on error, else 0.
>    */
>   int generic_update_time(struct inode *inode, int flags)
>   {
> @@ -2103,7 +2103,7 @@ int generic_update_time(struct inode *inode, int flags)
>   	if (updated & S_VERSION)
>   		dirty_flags |= I_DIRTY_SYNC;
>   	__mark_inode_dirty(inode, dirty_flags);
> -	return updated;
> +	return 0;
>   }
>   EXPORT_SYMBOL(generic_update_time);
>   
> @@ -2335,7 +2335,7 @@ static int file_update_time_flags(struct file *file, unsigned int flags)
>   	if (inode->i_op->update_time)
>   		ret = inode->i_op->update_time(inode, sync_mode);
>   	else
> -		generic_update_time(inode, sync_mode);
> +		ret = generic_update_time(inode, sync_mode);
>   	mnt_put_write_access_file(file);
>   	return ret;
>   }

ret is assigned here ...

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck