[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <024eb64f-74bd-4170-a6c1-09c4af647926@kernel.org>
Date: Mon, 17 Nov 2025 08:11:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jun Guo <jun.guo@...tech.com>, peter.chen@...tech.com,
fugang.duan@...tech.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, vkoul@...nel.org, ychuang3@...oton.com,
schung@...oton.com, robin.murphy@....com
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs
On 17/11/2025 08:07, Jun Guo wrote:
>
> On 11/17/2025 2:11 PM, Krzysztof Kozlowski wrote:
>> On 17/11/2025 02:59, Jun Guo wrote:
>>> - Add new compatible strings to the DT binding documents to support
>> This is not a list.
>>
>> Also, subject is completely redundant. Everything is an update. Why are
>> you repeating DT binding docs?
>>
> Thank you. I will incorporate your feedback in the next version.>> cix
> sky1 SoC.
>>>
>>> Signed-off-by: Jun Guo<jun.guo@...tech.com>
>>> ---
>> You just broke all existing platforms. Please test your code properly.
> The patch includes proper checks. Since this platform is the first user
Nah, tests are here incomplete - look at the binding and DTS users...
nothing there, so you cannot test it.
> of the driver in the current codebase, the change won't affect other
> platforms.
NAK, and you keep pushing... I just told you it will break everyone,
which is obvious from the diff.
Best regards,
Krzysztof
Powered by blists - more mailing lists