[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <80ce9e2e-3e18-4782-aa6a-2b6913c327df@kernel.org>
Date: Mon, 17 Nov 2025 08:20:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kumari Pallavi <kumari.pallavi@....qualcomm.com>,
kpallavi@....qualcomm.com, srini@...nel.org, amahesh@....qualcomm.com,
arnd@...db.de, gregkh@...uxfoundation.org
Cc: quic_bkumar@...cinc.com, ekansh.gupta@....qualcomm.com,
linux-kernel@...r.kernel.org, quic_chennak@...cinc.com,
dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
jingyi.wang@....qualcomm.com, aiqun.yu@....qualcomm.com,
ktadakam@....qualcomm.com
Subject: Re: [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible
for Kaanapali
On 17/11/2025 08:17, Kumari Pallavi wrote:
>
>
> On 11/14/2025 9:17 PM, Krzysztof Kozlowski wrote:
>> On 14/11/2025 09:41, Kumari Pallavi wrote:
>>> Add a new compatible string "qcom,kaanapali-fastrpc" to support
>>> for Kaanapali SoC.
>>>
>>> Signed-off-by: Kumari Pallavi <kumari.pallavi@....qualcomm.com>
>>> ---
>>
>> You not only did not bother to test it - there are obvious bugs here -
>> but you also did not send it to mailing lists for actual testing by
>> Rob's bot.
>>
>> NAK
>>
>> Best regards,
>> Krzysztof
>
> Thank you for the feedback. I did run the schema validation locally using:
> make dt_binding_check
> (as per
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/),
> and the build completed successfully without any errors.
But you did not read warnings and messages shown to you...
That's still obviously NAK.
Best regards,
Krzysztof
Powered by blists - more mailing lists