linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix aux device unplugging when rdma is not supported by vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09f58140-8d9c-42f3-a9f4-380c30d7c11e@molgen.mpg.de>
Date: Mon, 17 Nov 2025 08:25:50 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Larysa Zaremba <larysa.zaremba@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
 intel-wired-lan@...ts.osuosl.org,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Emil Tantilov <emil.s.tantilov@...el.com>,
 Madhu Chittim <madhu.chittim@...el.com>, Josh Hay <joshua.a.hay@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix aux device unplugging
 when rdma is not supported by vport

Dear Larysa,

Thank you for your patch.

Am 17.11.25 um 08:03 schrieb Larysa Zaremba:
> If vport flags do not contain VIRTCHNL2_VPORT_ENABLE_RDMA, driver does not
> allocate vdev_info for this vport. This leads to kernel NULL pointer
> dereference in idpf_idc_vport_dev_down(), which references vdev_info for
> every vport regardless.

Please paste part of the Oops log lines.

> Check, if vdev_info was ever allocated before unplugging aux device.

Please describe your test system.

> Fixes: be91128c579c ("idpf: implement RDMA vport auxiliary dev create, init, and destroy")
> Reviewed-by: Madhu Chittim <madhu.chittim@...el.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_idc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c
> index c1b963f6bfad..4b1037eb2623 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c
> @@ -322,7 +322,7 @@ static void idpf_idc_vport_dev_down(struct idpf_adapter *adapter)
>   	for (i = 0; i < adapter->num_alloc_vports; i++) {
>   		struct idpf_vport *vport = adapter->vports[i];
>   
> -		if (!vport)
> +		if (!vport || !vport->vdev_info)
>   			continue;
>   
>   		idpf_unplug_aux_dev(vport->vdev_info->adev);

The diff looks good.

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Kind regards,

Paul