linux-kernel - Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03a64900-8ef3-40b9-94bf-c953de824902@gocontroll.com>
Date: Mon, 17 Nov 2025 08:33:41 +0100
From: Maud Spierings <maudspierings@...ontroll.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix
 compatible

Hi Krzysztof,

Thanks for the review.

On 11/15/25 12:53, Krzysztof Kozlowski wrote:
> On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
>> The compatibles should include the SoM compatible, this board is based
>> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
>> the board compatible.
>>
>> This is a breaking change, but it is early enough that it can be
>> corrected without causing any issues.
>>
>> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
>> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
>> ---
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 21b7168d61f5..8949a98acd87 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1105,7 +1105,6 @@ properties:
>>                 - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
>> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>>                 - prt,prt8ml             # Protonic PRT8ML
>>                 - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>>                 - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
>> @@ -1163,6 +1162,12 @@ properties:
>>             - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>>             - const: fsl,imx8mp
>>   
>> +      - description: Ka-Ro TX8P-ML81 SoM based boards
>> +        items:
>> +          - const: gocontroll,moduline-display-106
> 
> You need old compatible here as well, you cannot drop it.

The old compatible should stay in the above section then right? Because 
the old compatible never matched the pattern with the SoM compatible. 
Should/can I add some deprecated tag to it then?

> I don't understand why you need board revision - commit msg should
> explain that.

It is to resolve certain quirks in userspace/bootloader, I will add it 
to the commit version in the next version.

The SoM compatible will be used in barebox to trigger shared code that 
applies to this SoM, I will add that better to the commit message too. I 
believe that also resolves the comments on patch 2/3

Kind Regards,
Maud
>> +          - const: karo,tx8p-ml81
>> +          - const: fsl,imx8mp
> 
> Best regards,
> Krzysztof
>