linux-kernel - Re: [PATCH] drm/msm/dpu: Set vsync source irrespective of mdp top support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYUPR06MB60990F649387CA675ADF2813DDC9A@TYUPR06MB6099.apcprd06.prod.outlook.com>
Date: Mon, 17 Nov 2025 07:55:08 +0000
From: Teguh Sobirin <teguh@...ir.in>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Rob Clark <robin.clark@....qualcomm.com>, Dmitry Baryshkov
	<lumag@...nel.org>, Abhinav Kumar <abhinav.kumar@...ux.dev>, Jessica Zhang
	<jesszhan0024@...il.com>, Sean Paul <sean@...rly.run>, Marijn Suijten
	<marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, Simona
 Vetter <simona@...ll.ch>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "freedreno@...ts.freedesktop.org"
	<freedreno@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dpu: Set vsync source irrespective of mdp top
 support


> 
> On 14 Nov 2025, at 12.10, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
> 
> On Tue, Oct 28, 2025 at 07:02:28PM +0200, Dmitry Baryshkov wrote:
>>> On Tue, Oct 28, 2025 at 08:36:35PM +0800, Teguh Sobirin wrote:
>>> Move the loop over phys_encs outside the
>>> hw_mdptop->ops.setup_vsync_source block.
>>> This way, vsync_sel() is called for each interface.
>>> 
>>> This change ensures TE vsync selection works
>>> even if setup_vsync_source is not implemented.
>> 
>> Please see Documentation/processs/submitting-patches.rst. Don't describe
>> the change and pleasw wrap the commit message on 72-75 chars boundary.
>> 
>> I can suggest something like this:
>> 
>> Since DPU 5.x the vsync source TE setup is split between MDP TOP and
>> INTF blocks.  Currently all code to setup vsync_source is only exectued
>> if MDP TOP implements the setup_vsync_source() callback. However on
>> DPU >= 8.x this callback is not implemented, making DPU driver skip all
>> vsync setup. Move the INTF part out of this condition, letting DPU
>> driver to setup TE vsync selection on all new DPU devices.
>> 
>> The patch itself looks good to me.
> 
> 
> Teguh, any updates on the patch?
> 
> --
> With best wishes
> Dmitry

I will send a new one with corrected commit message

Regards,
Teguh.