linux-kernel - [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251117093137.572132-3-jolsa@kernel.org>
Date: Mon, 17 Nov 2025 10:31:34 +0100
From: Jiri Olsa <jolsa@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org,
	x86@...nel.org,
	Ingo Molnar <mingo@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>
Subject: [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg_offset

It's not used, get_reg_offset returns only offset to struct pt_regs,
not the actual register values.

Signed-off-by: Jiri Olsa <jolsa@...nel.org>
---
 arch/x86/lib/insn-eval.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c
index 7b46eb717066..8b9c2b90d66e 100644
--- a/arch/x86/lib/insn-eval.c
+++ b/arch/x86/lib/insn-eval.c
@@ -519,8 +519,7 @@ static int get_regno(struct insn *insn, enum reg_type type)
 	return regno;
 }
 
-static int get_reg_offset(struct insn *insn, struct pt_regs *regs,
-			  enum reg_type type)
+static int get_reg_offset(struct insn *insn, enum reg_type type)
 {
 	int regno = get_regno(insn, type);
 
@@ -861,7 +860,7 @@ int insn_get_code_seg_params(struct pt_regs *regs)
  */
 int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs)
 {
-	return get_reg_offset(insn, regs, REG_TYPE_RM);
+	return get_reg_offset(insn, REG_TYPE_RM);
 }
 
 /**
@@ -876,7 +875,7 @@ int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs)
  */
 int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs)
 {
-	return get_reg_offset(insn, regs, REG_TYPE_REG);
+	return get_reg_offset(insn, REG_TYPE_REG);
 }
 
 /**
@@ -982,7 +981,7 @@ static int get_eff_addr_reg(struct insn *insn, struct pt_regs *regs,
 	if (X86_MODRM_MOD(insn->modrm.value) != 3)
 		return -EINVAL;
 
-	*regoff = get_reg_offset(insn, regs, REG_TYPE_RM);
+	*regoff = get_reg_offset(insn, REG_TYPE_RM);
 	if (*regoff < 0)
 		return -EINVAL;
 
@@ -1035,7 +1034,7 @@ static int get_eff_addr_modrm(struct insn *insn, struct pt_regs *regs,
 	if (X86_MODRM_MOD(insn->modrm.value) > 2)
 		return -EINVAL;
 
-	*regoff = get_reg_offset(insn, regs, REG_TYPE_RM);
+	*regoff = get_reg_offset(insn, REG_TYPE_RM);
 
 	/*
 	 * -EDOM means that we must ignore the address_offset. In such a case,
@@ -1181,8 +1180,8 @@ static int get_eff_addr_sib(struct insn *insn, struct pt_regs *regs,
 	if (!insn->sib.nbytes)
 		return -EINVAL;
 
-	*base_offset = get_reg_offset(insn, regs, REG_TYPE_BASE);
-	indx_offset = get_reg_offset(insn, regs, REG_TYPE_INDEX);
+	*base_offset = get_reg_offset(insn, REG_TYPE_BASE);
+	indx_offset = get_reg_offset(insn, REG_TYPE_INDEX);
 
 	/*
 	 * Negative values in the base and index offset means an error when
-- 
2.51.1