linux-kernel - Re: [PATCH] crypto: padlock-sha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c24d0582-ae94-4dfb-ae6f-6baafa7fe689@zhaoxin.com>
Date: Mon, 17 Nov 2025 17:03:17 +0800
From: AlanSong-oc <AlanSong-oc@...oxin.com>
To: Eric Biggers <ebiggers@...nel.org>, <linux-crypto@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
CC: <linux-kernel@...r.kernel.org>, larryw3i <larryw3i@...h.net>,
	<stable@...r.kernel.org>, <CobeChen@...oxin.com>, <GeorgeXue@...oxin.com>,
	<HansHu@...oxin.com>, <LeoLiu-oc@...oxin.com>, <TonyWWang-oc@...oxin.com>,
	<YunShen@...oxin.com>
Subject: Re: [PATCH] crypto: padlock-sha - Disable broken driver

On 11/17/2025 2:39 AM, Eric Biggers wrote:

> This driver is known broken, as it computes the wrong SHA-1 and SHA-256
> hashes.  Correctness needs to be the first priority for cryptographic
> code.  Just disable it, allowing the standard (and actually correct)
> SHA-1 and SHA-256 implementations to take priority.
>  

Following Herbert Xu's 
suggestion（https://lore.kernel.org/linux-crypto/aFkdNoQFmr8-x4cu@gondor.apana.org.au/）, 
we have prepared a new version of the patch to address this issue. Since 
the code needs to remain compatible with older platforms, we are still 
conducting extensive testing. Once the testing is complete, I will 
submit the finalized patch immediately.

Best Regards
AlanSong-oc