linux-kernel - Re: [PATCH] lockdep: Add header and footer to surround warning reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRqLX2F4ae7hApng@google.com>
Date: Mon, 17 Nov 2025 02:41:35 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
	Waiman Long <longman@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: Add header and footer to surround warning
 reports

On Sat, Nov 15, 2025 at 05:36:43PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@...nel.org> wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
> >                 return;
> >
> >         pr_warn("\n");
> > +       pr_warn(CUT_HERE);
> >         pr_warn("======================================================\n");
> 
> I guess you can drop all lines printing a separator made of equal signs,
> as CUT_HERE already contains a graphical separator.

I'm not sure if we'd like to maintain the "backward compatibility".  I.e.,
if there are already some tools rely on the "====" to parse the report,
should we consider to preserve the equal sign separators?

Happy to receive some more feedback.