linux-kernel - Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D703D9B7-69D0-4E64-9CB3-31BD63FF2478@exactco.de>
Date: Mon, 17 Nov 2025 11:16:07 +0100
From: René Rebe <rene@...ctco.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Christoph Hellwig <hch@....de>,
 Jens Axboe <axboe@...nel.dk>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Geoff Levand <geoff@...radead.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index

Hi,

> On 17. Nov 2025, at 10:47, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> 
> Hi Greg,
> 
> On Sun, 16 Nov 2025 at 13:14, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> On Fri, Nov 14, 2025 at 03:30:33PM +0100, Rene Rebe wrote:
>>> With 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) converting
>>> ps3disk to new bvec helpers, incrementing the offset was accidently
>>> lost, corrupting consecutive buffers. Restore index for non-corrupted
>>> data transfers.
>>> 
>>> Fixes: 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec)
>>> 
>>> Signed-off-by: René Rebe <rene@...ctco.de>
>>> 
>>> --- a/drivers/block/ps3disk.c 2023-08-07 17:40:55.200957746 +0200
>>> +++ b/drivers/block/ps3disk.c 2023-08-07 17:46:39.702964129 +0200
>>> @@ -85,10 +93,14 @@
>>>      struct bio_vec bvec;
>>> 
>>>      rq_for_each_segment(bvec, req, iter) {
>>> +             dev_dbg(&dev->sbd.core, "%s:%u: %u sectors from %llu\n",
>>> +                     __func__, __LINE__, bio_sectors(iter.bio),
>> 
>> In the future, please note that all dev_dbg() calls have __func__ built
>> into them, and I think __LINE__ as well, so there's no need to ever add
>> that to the output.  Take a look at the documentation for more details
>> on how to see that in the log.
> 
> That does not seem to be true in v6.18-rc6: the function name and line
> number are not included.

Thanks, I will keep that in mind for future patches, in this case I only
Exactly restored what was deleted by the broken commit.

	René

-- 
https://exactco.de - https://t2linux.com - https://rene.rebe.de