linux-kernel - Re: [PATCH RESEND 1/5] block/blk-rq-qos: add a new helper rq_qos_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68571a38-64ca-43e3-ad2b-977370179a42@linux.ibm.com>
Date: Mon, 17 Nov 2025 15:40:01 +0530
From: Nilay Shroff <nilay@...ux.ibm.com>
To: Yu Kuai <yukuai@...as.com>, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, tj@...nel.org, ming.lei@...hat.com
Subject: Re: [PATCH RESEND 1/5] block/blk-rq-qos: add a new helper
 rq_qos_add_freezed()



On 11/16/25 9:40 AM, Yu Kuai wrote:
> queue should not be freezed under rq_qos_mutex, see example index
> commit 9730763f4756 ("block: correct locking order for protecting blk-wbt
> parameters"), which means current implementation of rq_qos_add() is
> problematic. Add a new helper and prepare to fix this problem in
> following patches.
> 
> Signed-off-by: Yu Kuai <yukuai@...as.com>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay@...ux.ibm.com>