linux-kernel - Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251117105542.14789-1-eleanor.lin@realtek.com>
Date: Mon, 17 Nov 2025 18:55:42 +0800
From: Yu-Chun Lin <eleanor.lin@...ltek.com>
To: <conor@...nel.org>
CC: <afaerber@...e.de>, <conor+dt@...nel.org>, <cy.huang@...ltek.com>,
        <devicetree@...r.kernel.org>, <eleanor.lin@...ltek.com>,
        <james.tai@...ltek.com>, <krzk+dt@...nel.org>, <lee@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-realtek-soc@...ts.infradead.org>, <robh@...nel.org>,
        <stanley_chang@...ltek.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles

On Thu, Nov 13, 2025 at 08:30:07PM +0800, Yu-Chun Lin wrote:
> > Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s.
> > 
> > Additionally, convert legacy DTS-style comments to YAML description 
> > properties, following the pattern from the ARM bindings conversion 
> > series [1].
>
> "Additionally" is often a sign that it should be in a different patch.
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> pw-bot: not-applicable

Hi Conor,

I'm planning to split the changes into two separate patches:

1. One patch to convert realtek.yaml to match the DTS-style comments,
following the pattern from the ARM bindings conversion series.
2. Another patch to define the compatible strings for Realtek RTD1501s,
RTD1861b, and RTD1920s.

Could you confirm if both patches should include your Acked-by tag, or is
it only applicable to one of them?

Best regards 
Yu-Chun

> > 
> > [1] 
> > https://lore.kernel.org/lkml/20200622125527.24207-2-afaerber@suse.de/
> > 
> > Signed-off-by: Yu-Chun Lin <eleanor.lin@...ltek.com>
> > ---
> >  .../devicetree/bindings/arm/realtek.yaml      | 42 +++++++++++++------
> >  1 file changed, 30 insertions(+), 12 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml 
> > b/Documentation/devicetree/bindings/arm/realtek.yaml
> > index ddd9a85099e9..be529490640c 100644
> > --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> > @@ -14,21 +14,21 @@ properties:
> >      const: '/'
> >    compatible:
> >      oneOf:
> > -      # RTD1195 SoC based boards
> > -      - items:
> > +      - description: RTD1195 SoC based boards
> > +        items:
> >            - enum:
> >                - mele,x1000 # MeLE X1000
> >                - realtek,horseradish # Realtek Horseradish EVB
> >            - const: realtek,rtd1195
> >  
> > -      # RTD1293 SoC based boards
> > -      - items:
> > +      - description: RTD1293 SoC based boards
> > +        items:
> >            - enum:
> >                - synology,ds418j # Synology DiskStation DS418j
> >            - const: realtek,rtd1293
> >  
> > -      # RTD1295 SoC based boards
> > -      - items:
> > +      - description: RTD1295 SoC based boards
> > +        items:
> >            - enum:
> >                - mele,v9 # MeLE V9
> >                - probox2,ava # ProBox2 AVA @@ -36,25 +36,43 @@ 
> > properties:
> >                - zidoo,x9s # Zidoo X9S
> >            - const: realtek,rtd1295
> >  
> > -      # RTD1296 SoC based boards
> > -      - items:
> > +      - description: RTD1296 SoC based boards
> > +        items:
> >            - enum:
> >                - synology,ds418 # Synology DiskStation DS418
> >            - const: realtek,rtd1296
> >  
> > -      # RTD1395 SoC based boards
> > -      - items:
> > +      - description: RTD1395 SoC based boards
> > +        items:
> >            - enum:
> >                - bananapi,bpi-m4 # Banana Pi BPI-M4
> >                - realtek,lion-skin # Realtek Lion Skin EVB
> >            - const: realtek,rtd1395
> >  
> > -      # RTD1619 SoC based boards
> > -      - items:
> > +      - description: RTD1501s SoC based boards
> > +        items:
> > +          - enum:
> > +              - realtek,phantom # Realtek Phantom EVB (8GB)
> > +          - const: realtek,rtd1501s
> > +
> > +      - description: RTD1619 SoC based boards
> > +        items:
> >            - enum:
> >                - realtek,mjolnir # Realtek Mjolnir EVB
> >            - const: realtek,rtd1619
> >  
> > +      - description: RTD1861b SoC based boards
> > +        items:
> > +          - enum:
> > +              - realtek,krypton # Realtek Krypton EVB (8GB)
> > +          - const: realtek,rtd1861b
> > +
> > +      - description: RTD1920s SoC based boards
> > +        items:
> > +          - enum:
> > +              - realtek,smallville # Realtek Smallville EVB (4GB)
> > +          - const: realtek,rtd1920s
> > +
> >  additionalProperties: true
> >  
> >  ...
> > --
> > 2.34.1
> >