linux-kernel - Re: [PATCH linux] netfilter: conntrack: Add missing modification about data-race around ct->timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRsA1a-1_NWsYst3@strlen.de>
Date: Mon, 17 Nov 2025 12:02:45 +0100
From: Florian Westphal <fw@...len.de>
To: Chenguang Zhao <zhaochenguang@...inos.cn>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>, Phil Sutter <phil@....cc>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux] netfilter: conntrack: Add missing modification
 about data-race around ct->timeout

Chenguang Zhao <zhaochenguang@...inos.cn> wrote:
> Add missing modification about data-race around ct->timeout

This could use a bit more verbose explanation.

>  	   weird delay cases. */
> -	ct->timeout += nfct_time_stamp;
> +	WRITE_ONCE(ct->timeout, ct->timeout + nfct_time_stamp);
                                ~~~~~~~~~~~

Shouldn't that be

WRITE_ONCE(ct->timeout, READ_ONCE(ct->timeout) + nfct_time_stamp); ?

Furthermore, patch subject should list either [nf] or [nf-next] to
indicate the tree you want this patch applied to.