linux-kernel - Re: [PATCH v3 4/6] dt-bindings: display: sun4i: Add D1s/T113 combo D-PHY bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0347d10-475d-4dd2-b53e-ca7905869887@szczodrzynski.pl>
Date: Mon, 17 Nov 2025 12:08:32 +0100
From: Kuba Szczodrzyński <kuba@...zodrzynski.pl>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Maxime Ripard <mripard@...nel.org>, Samuel Holland <samuel@...lland.org>,
 Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 parthiban@...umiz.com, paulk@...-base.io
Subject: Re: [PATCH v3 4/6] dt-bindings: display: sun4i: Add D1s/T113 combo
 D-PHY bindings

W dniu 2025-11-17 o 08:05:33, Krzysztof Kozlowski pisze:

> On Sun, Nov 16, 2025 at 02:49:43PM +0100, Kuba Szczodrzyński wrote:
>> The sun4i TCON needs a reference to the D-PHY in order to support LVDS
>> on Allwinner D1s/T113.
>>
>> Add phys and phy-names to DT bindings.
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets. See also:
> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

I'll resend v4 as a new patchset.

>
>> Signed-off-by: Kuba Szczodrzyński <kuba@...zodrzynski.pl>
>> ---
>>   .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> index 724d93b91..52589341f 100644
>> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> @@ -115,6 +115,12 @@ properties:
>>             - const: edp
>>             - const: lvds
>>   
>> +  phys:
>> +    maxItems: 1
>> +
>> +  phy-names:
>> +    const: combo-phy
> Drop phy suffix. Can a "phy" property hold reference to something else
> than phy?

Will do.

> You don't need names in the first place, you have only one
> entry.

However, phy-names was added because of how other bindings are made, such as "allwinner,sun4i-a10-musb" (single phy entry with const name).

So I think it makes sense to keep it, in line with other drivers.

Regards
Kuba

>
> Best regards,
> Krzysztof
>