linux-kernel - Re: [PATCH v2] gfs2: fix freeze error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU7p1NOfX_=aNEJsMSWCMHfbojbg5LGMUarOyqcdNq-Q2Q@mail.gmail.com>
Date: Mon, 17 Nov 2025 13:12:23 +0100
From: Andreas Gruenbacher <agruenba@...hat.com>
To: Alexey Velichayshiy <a.velichayshiy@...ras.ru>
Cc: gfs2@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] gfs2: fix freeze error handling

On Mon, Nov 17, 2025 at 10:06 AM Alexey Velichayshiy
<a.velichayshiy@...ras.ru> wrote:
> After commit b77b4a4815a9 ("gfs2: Rework freeze / thaw logic"),
> the freeze error handling is broken because gfs2_do_thaw()
> overwrites the 'error' variable, causing incorrect processing
> of the original freeze error.
>
> Fix this by calling gfs2_do_thaw() when gfs2_lock_fs_check_clean()
> fails but ignoring its return value to preserve the original
> freeze error for proper reporting.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexey Velichayshiy <a.velichayshiy@...ras.ru>
> ---
>  fs/gfs2/super.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
> index 644b2d1e7276..54c6f2098f01 100644
> --- a/fs/gfs2/super.c
> +++ b/fs/gfs2/super.c
> @@ -749,9 +749,7 @@ static int gfs2_freeze_super(struct super_block *sb, enum freeze_holder who,
>                         break;
>                 }
>
> -               error = gfs2_do_thaw(sdp, who, freeze_owner);
> -               if (error)
> -                       goto out;
> +               (void)gfs2_do_thaw(sdp, who, freeze_owner);
>
>                 if (error == -EBUSY)
>                         fs_err(sdp, "waiting for recovery before freeze\n");
> --
> 2.43.0
>

Applied to for-next, thank you.

Andreas