[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee2123ee-c500-4db6-bc9a-2e5fcbeb8ae6@oss.qualcomm.com>
Date: Mon, 17 Nov 2025 13:40:29 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Barnabás Czémán <barnabas.czeman@...nlining.org>,
Bjorn Andersson <andersson@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd
<sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Adam Skladowski <a_skl39@...tonmail.com>,
Sireesh Kodali <sireeshkodali@...tonmail.com>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Lanik <daniilt971@...il.com>
Subject: Re: [PATCH 4/4] clk: qcom: gcc: Add support for Global Clock
controller found on SDM439
On 11/16/25 10:35 PM, Barnabás Czémán wrote:
> From: Lanik <daniilt971@...il.com>
>
> Modify existing MSM8917 driver to support SDM439 SoC. SDM439 SoC has the
> same changes as MSM8937 SoC, but with different gpll3 vco rate and
> different GFX3D clock frequency table.
>
> Signed-off-by: Lanik <daniilt971@...il.com>
This doesn't seem like a proper full name, please fix up your git
config
[...]
> +static void sdm439_clock_override(void)
> +{
> + /*
> + * Set below clocks for use specific sdm439 parent map.
> + */
> + vcodec0_clk_src.parent_map = gcc_cpp_map;
> + vcodec0_clk_src.clkr.hw.init = &vcodec0_clk_src_init_msm8937;
> +
> + /*
> + * Set below clocks for use specific sdm439 freq table.
> + */
These comments are rather self-explanatory, you can drop them
Konrad
Powered by blists - more mailing lists