linux-kernel - Re: [PATCH v3 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56a3a993-9e54-4468-8774-5ed350948ab5@altera.com>
Date: Mon, 17 Nov 2025 03:02:11 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Conor Dooley <conor@...nel.org>
CC: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>, Tom Rix
	<trix@...hat.com>, Dinh Nguyen <dinguyen@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "Rao, Mahesh" <mahesh.rao@...era.com>, "Ng, Adrian Ho
 Yin" <adrian.ho.yin.ng@...era.com>, "Rabara, Niravkumar Laxmidas"
	<nirav.rabara@...era.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: fpga: stratix10: add support for
 Agilex5

On 15/11/2025 1:59 am, Conor Dooley wrote:
> On Fri, Nov 14, 2025 at 02:27:41PM +0800, Khairul Anuar Romli wrote:
>> Agilex5 introduces changes in how reserved memory is mapped and accessed
>> compared to previous SoC generations. Agilex5 compatible allows stratix10-
>> FPGA manager driver to handle these changes.
>>
>> Fallback is added for driver probe and init that rely on matching of table
>> and DT node.
>>
>> Reviewed-by: Xu Yilun <yilun.xu@...el.com>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
>> ---
>> Changes in v3:
>> 	- Add description for Agilex5 Device
>> 	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
>> 	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
>> 	  (fallback)
>> Changes in v2:
>> 	- No changes in this patch
>> ---
>>   .../fpga/intel,stratix10-soc-fpga-mgr.yaml         | 14 +++++++++++---
>>   1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> index 6e536d6b28a9..8eb414163d08 100644
>> --- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> +++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
>> @@ -20,9 +20,17 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - intel,stratix10-soc-fpga-mgr
>> -      - intel,agilex-soc-fpga-mgr
>> +    oneOf:
>> +      - items:
>> +          - enum:
> 
> This construct is redundant, "items: - enum" is the same as just having
> "enum".
> pw-bot: changes-requested
> 
I've tried to look for some of the already merged bindings i.e 
arm/qcom.yaml (although all the properties has enum - constant 
combination), it is using items with enum. I tried to keep the enum without
items but I keep getting error while validating the changes.

Another option that I've validated is using the following changes.

-    enum:
-      - intel,stratix10-soc-fpga-mgr
-      - intel,agilex-soc-fpga-mgr
+    oneOf:
+      - description: Intel Stratix10 Devices
+        items:
+          - const: intel,stratix10-soc-fpga-mgr
+      - description: Intel Agilex Devices
+        items:
+          - const: intel,agilex-soc-fpga-mgr
+      - description: Intel Agilex5 Devices
+        items:
+          - const: intel,agilex5-soc-fpga-mgr
+          - const: intel,agilex-soc-fpga-mgr

The drawback of this is we will need to implement enum instead of 
constant for first element if we need to add new devices under "Intel 
Agilex5 Devices" in the future.

Thanks.

Best Regards,
Khairul

>> +              - intel,stratix10-soc-fpga-mgr
>> +              - intel,agilex-soc-fpga-mgr
>> +
>> +      - description: Agilex5 Device
>> +        items:
>> +          - enum:
>> +              - intel,agilex5-soc-fpga-mgr
>> +          - const: intel,agilex-soc-fpga-mgr
>>   
>>   required:
>>     - compatible
>> -- 
>> 2.43.7
>>