linux-kernel - Re: [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeuX1BWnx5wH=c9WwuiC10H3SOEPJetYhQ59mJhgBGGqA@mail.gmail.com>
Date: Tue, 18 Nov 2025 14:04:43 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 2/3] pinctrl: intel: Export intel_gpio_add_pin_ranges()

On Tue, Nov 18, 2025 at 1:47 PM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Mon, Nov 17, 2025 at 08:57:00AM +0100, Andy Shevchenko wrote:
> > Export intel_gpio_add_pin_ranges() for reuse in other drivers.

...

> > -static int intel_gpio_add_pin_ranges(struct gpio_chip *gc)
>
> As this is now exported, can you add kernel-doc too?

OK.

...

> > +int intel_gpio_add_pin_ranges(struct gpio_chip *gc);
>
> Can you move this down a bit, above intel_get_groups_count()?

Sure.

-- 
With Best Regards,
Andy Shevchenko