linux-kernel - Re: [PATCH v2] btrfs: simplify async csum synchronization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118120716.GT13846@twin.jikos.cz>
Date: Tue, 18 Nov 2025 13:07:16 +0100
From: David Sterba <dsterba@...e.cz>
To: Daniel Vacek <neelx@...e.com>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, Qu Wenruo <wqu@...e.com>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: simplify async csum synchronization

On Thu, Nov 13, 2025 at 11:17:30AM +0100, Daniel Vacek wrote:
> We don't need the redundant completion csum_done which marks the
> csum work has been executed. We can simply flush_work() instead.
> 
> This way we can slim down the btrfs_bio structure by 32 bytes matching
> it's size to what it used to be before introducing the async csums.
> Hence not making any change with respect to the structure size.
> ---
> This is a simple fixup for "btrfs: introduce btrfs_bio::async_csum" in
> for-next and can be squashed into it.
> 
> v2: metadata is not checksummed here so use the endio_workers workqueue
>     unconditionally. Thanks to Qu Wenruo.

This looks quite useful regarding the size reduction of btrfs_bio,
please fold it to the patch. Thanks.