linux-kernel - Re: [PATCH v2 1/1] PCI: stm32: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRxpsc02hGW1w_hu@black.igk.intel.com>
Date: Tue, 18 Nov 2025 13:42:25 +0100
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>, Jonathan Cameron <jic23@...nel.org>
Cc: Christian Bruel <christian.bruel@...s.st.com>,
	linux-pci@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>
Subject: Re: [PATCH v2 1/1] PCI: stm32: Don't use "proxy" headers

On Mon, Nov 17, 2025 at 02:43:48PM -0600, Bjorn Helgaas wrote:
> On Fri, Nov 14, 2025 at 07:52:01PM +0100, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> > 
> > In particular, replace of_gpio.h, which is subject to remove by the GPIOLIB
> > subsystem, with the respective headers that are being used by the driver.
> 
> Thanks, Andy!  It looks like a lot of work to figure this out by hand.

True.

> Is there a tool to figure this out?  Maybe something I could run when
> reviewing patches?

I have a déjà vu answering this question. Was it you last time who asked
the same?

The tool is iwyu which is heavily tuned for the kernel use by Jonathan (Cc'ed).
But I do it manually.

> IWYU seems like a nice principle but I couldn't find any mention in
> Documentation/.  Should it be covered there somehow?

Perhaps. Maybe we can start with IIO, where it's a highly recommended thing
for the new code submissions.

-- 
With Best Regards,
Andy Shevchenko