| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20251118125148.95603-6-wenliang202407@163.com>
Date: Tue, 18 Nov 2025 07:51:45 -0500
From: Wenliang Yan <wenliang202407@....com>
To: linux@...ck-us.net,
Jean Delvare <jdelvare@...e.com>
Cc: Wenliang Yan <wenliang202407@....com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Jonathan Corbet <corbet@....net>,
linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH v2 5/8] hwmon: (ina3221) Introduce power attribute and alert characteristics
SQ52210 has built-in current and power sensors as well as multiple
alert functions. Add power attributes and different critical
characteristics in hwmon to report the corresponding data.
Signed-off-by: Wenliang Yan <wenliang202407@....com>
---
Documentation/hwmon/ina3221.rst | 24 ++++++++++++++
drivers/hwmon/ina3221.c | 57 ++++++++++++++++++++++++++++++---
2 files changed, 77 insertions(+), 4 deletions(-)
diff --git a/Documentation/hwmon/ina3221.rst b/Documentation/hwmon/ina3221.rst
index 8c12c54d2c24..224c6cf735ed 100644
--- a/Documentation/hwmon/ina3221.rst
+++ b/Documentation/hwmon/ina3221.rst
@@ -13,6 +13,13 @@ Supported chips:
https://www.ti.com/
+ * Silergy SQ52210
+
+ Prefix: 'SQ52210'
+
+ Addresses: I2C 0x40 - 0x43
+
+
Author: Andrew F. Davis <afd@...com>
Description
@@ -23,6 +30,9 @@ side of up to three D.C. power supplies. The INA3221 monitors both shunt drop
and supply voltage, with programmable conversion times and averaging, current
and power are calculated host-side from these.
+The SQ52210 is a mostly compatible chip from Silergy. It incorporates internal
+current and power registers, and provides an extra configurable alert function.
+
Sysfs entries
-------------
@@ -72,3 +82,17 @@ update_interval Data conversion time in millisecond, following:
Note that setting update_interval to 0ms sets both BC
and SC to 140 us (minimum conversion time).
======================= =======================================================
+
+Additional sysfs entries for sq52210
+-------------------------------------
+
+======================= =======================================================
+in[123]_crit Critical high bus voltage
+in[123]_crit_alarm Bus voltage critical high alarm
+in[123]_lcrit Critical low bus voltage
+in[123]_lcrit_alarm Bus voltage critical low alarm
+curr[123]_lcrit Critical low current
+curr[123]_lcrit_alarm Current critical low alarm
+power[123]_input Current for channels 1, 2, and 3 respectively
+power[123]_crit Critical high power
+power[123]_crit_alarm Power critical high alarm
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index 8ea75f407055..1d589d402b52 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -645,6 +645,8 @@ static umode_t ina3221_is_visible(const void *drvdata,
{
const struct ina3221_data *ina = drvdata;
const struct ina3221_input *input = NULL;
+ bool has_alerts = ina->config->has_alerts;
+ bool has_power = ina->config->has_power;
switch (type) {
case hwmon_chip:
@@ -672,6 +674,16 @@ static umode_t ina3221_is_visible(const void *drvdata,
return 0444;
case hwmon_in_enable:
return 0644;
+ case hwmon_in_crit:
+ case hwmon_in_lcrit:
+ if (has_alerts)
+ return 0644;
+ return 0;
+ case hwmon_in_crit_alarm:
+ case hwmon_in_lcrit_alarm:
+ if (has_alerts)
+ return 0444;
+ return 0;
default:
return 0;
}
@@ -684,6 +696,31 @@ static umode_t ina3221_is_visible(const void *drvdata,
case hwmon_curr_crit:
case hwmon_curr_max:
return 0644;
+ case hwmon_curr_lcrit:
+ if (has_alerts)
+ return 0644;
+ return 0;
+ case hwmon_curr_lcrit_alarm:
+ if (has_alerts)
+ return 0444;
+ return 0;
+ default:
+ return 0;
+ }
+ case hwmon_power:
+ switch (attr) {
+ case hwmon_power_input:
+ if (has_power)
+ return 0444;
+ return 0;
+ case hwmon_power_crit_alarm:
+ if (has_alerts)
+ return 0444;
+ return 0;
+ case hwmon_power_crit:
+ if (has_alerts)
+ return 0644;
+ return 0;
default:
return 0;
}
@@ -694,7 +731,14 @@ static umode_t ina3221_is_visible(const void *drvdata,
#define INA3221_HWMON_CURR_CONFIG (HWMON_C_INPUT | \
HWMON_C_CRIT | HWMON_C_CRIT_ALARM | \
- HWMON_C_MAX | HWMON_C_MAX_ALARM)
+ HWMON_C_MAX | HWMON_C_MAX_ALARM | \
+ HWMON_C_LCRIT | HWMON_C_LCRIT_ALARM)
+#define SQ52210_HWMON_POWER_CONFIG (HWMON_P_INPUT | \
+ HWMON_P_CRIT | HWMON_P_CRIT_ALARM)
+#define SQ52210_HWMON_BUS_CONFIG (HWMON_I_INPUT | \
+ HWMON_I_ENABLE | HWMON_I_LABEL | \
+ HWMON_I_LCRIT_ALARM | HWMON_I_LCRIT |\
+ HWMON_I_CRIT_ALARM | HWMON_I_CRIT)
static const struct hwmon_channel_info * const ina3221_info[] = {
HWMON_CHANNEL_INFO(chip,
@@ -704,9 +748,9 @@ static const struct hwmon_channel_info * const ina3221_info[] = {
/* 0: dummy, skipped in is_visible */
HWMON_I_INPUT,
/* 1-3: input voltage Channels */
- HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
- HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
- HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
+ SQ52210_HWMON_BUS_CONFIG,
+ SQ52210_HWMON_BUS_CONFIG,
+ SQ52210_HWMON_BUS_CONFIG,
/* 4-6: shunt voltage Channels */
HWMON_I_INPUT,
HWMON_I_INPUT,
@@ -720,6 +764,11 @@ static const struct hwmon_channel_info * const ina3221_info[] = {
INA3221_HWMON_CURR_CONFIG,
/* 4: summation of current channels */
HWMON_C_INPUT | HWMON_C_CRIT | HWMON_C_CRIT_ALARM),
+ HWMON_CHANNEL_INFO(power,
+ /* 1-3: power channels*/
+ SQ52210_HWMON_POWER_CONFIG,
+ SQ52210_HWMON_POWER_CONFIG,
+ SQ52210_HWMON_POWER_CONFIG),
NULL
};
--
2.17.1
Powered by blists - more mailing lists