linux-kernel - Re: [PATCH V2 13/14] LoongArch: Adjust default config files for 32BIT/64BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <debb8b35-8253-4422-a197-6d92e8d0c701@app.fastmail.com>
Date: Tue, 18 Nov 2025 14:45:39 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Huacai Chen" <chenhuacai@...ngson.cn>,
 "Huacai Chen" <chenhuacai@...nel.org>
Cc: loongarch@...ts.linux.dev, Linux-Arch <linux-arch@...r.kernel.org>,
 "Xuefeng Li" <lixuefeng@...ngson.cn>, guoren <guoren@...nel.org>,
 "WANG Xuerui" <kernel@...0n.name>, "Jiaxun Yang" <jiaxun.yang@...goat.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 13/14] LoongArch: Adjust default config files for 32BIT/64BIT

On Tue, Nov 18, 2025, at 12:27, Huacai Chen wrote:
> Add loongson32_defconfig (for 32BIT) and rename loongson3_defconfig to
> loongson64_defconfig (for 64BIT).
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  arch/loongarch/configs/loongson32_defconfig   | 1110 +++++++++++++++++
>  ...ongson3_defconfig => loongson64_defconfig} |    0

I would suggest using .config fragment here and only listing
the differences in the defconfig files in there, rather than
duplicating everything.

> +CONFIG_DMI=y
> +CONFIG_EFI=y
> +CONFIG_SUSPEND=y
> +CONFIG_HIBERNATION=y
> +CONFIG_ACPI=y
> +CONFIG_ACPI_SPCR_TABLE=y
> +CONFIG_ACPI_TAD=y
> +CONFIG_ACPI_DOCK=y
> +CONFIG_ACPI_IPMI=m
> +CONFIG_ACPI_HOTPLUG_CPU=y
> +CONFIG_ACPI_PCI_SLOT=y
> +CONFIG_ACPI_HOTPLUG_MEMORY=y
> +CONFIG_ACPI_BGRT=y

You mention that loongarch32 uses ftb based boot,
so ACPI should probably be disabled here.

> +CONFIG_DRM=y
> +CONFIG_DRM_LOAD_EDID_FIRMWARE=y
> +CONFIG_DRM_RADEON=m
> +CONFIG_DRM_RADEON_USERPTR=y
> +CONFIG_DRM_AMDGPU=m
> +CONFIG_DRM_AMDGPU_SI=y
> +CONFIG_DRM_AMDGPU_CIK=y
> +CONFIG_DRM_AMDGPU_USERPTR=y
> +CONFIG_DRM_AST=y
> +CONFIG_DRM_QXL=m
> +CONFIG_DRM_VIRTIO_GPU=m
> +CONFIG_DRM_LOONGSON=y
> +CONFIG_DRM_SIMPLEDRM=y
> +CONFIG_FB=y
> +CONFIG_FB_EFI=y
> +CONFIG_FB_RADEON=y
> +CONFIG_FIRMWARE_EDID=y

Is AMDGPU actually working? This driver is rather tricky to get
reliable on new architectures.

I would suggest turning off CONFIG_FB here (also on loongarch64).
There is a replacement driver for FB_EFI in DRM now.

       Arnd