linux-kernel - Re: [PATCH v3 net] net: phylink: add missing supported link modes for the fixed-link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7222c87-3e4c-4170-993b-dbf5ba26c462@lunn.ch>
Date: Tue, 18 Nov 2025 15:00:00 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Wei Fang <wei.fang@....com>
Cc: Russell King <linux@...linux.org.uk>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"eric@...int.com" <eric@...int.com>,
	"maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 net] net: phylink: add missing supported link modes
 for the fixed-link

> > > Fixes: de7d3f87be3c ("net: phylink: Use phy_caps_lookup for fixed-link
> > > configuration")
> > > Signed-off-by: Wei Fang <wei.fang@....com>
> > > Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> > 
> > NAK. I give up.
> > 
> 
> Sorry, could you please tell me what the reason is?

I think Russell is referring to the commit message, and how you only
quoted a little section of his explanation. There is no limit to
commit messages, they don't need to be short. It is actually better if
they are long. So you could use his whole explanation. And then you
don't need the link.

	Andrew