linux-kernel - Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb34be74-6c9f-4bc8-b67e-31e387f7a850@kernel.org>
Date: Tue, 18 Nov 2025 15:12:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Deng <wei.deng@....qualcomm.com>, Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 quic_jiaymao@...cinc.com, Konrad Dybcio <konradybcio@...nel.org>,
 linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
 cheng.jiang@....qualcomm.com, devicetree@...r.kernel.org,
 Bjorn Andersson <andersson@...nel.org>, quic_shuaz@...cinc.com,
 quic_chezhou@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: monaco-evk: Enable Bluetooth support

On 18/11/2025 14:24, Wei Deng wrote:
> Hi Krzysztof,
> 
> Thanks for your comments.
> 
> On 11/18/2025 3:19 PM, Krzysztof Kozlowski wrote:
>> On 18/11/2025 08:07, Wei Deng wrote:
>>> Hi Rob,
>>>
>>> Thanks for your comments.
>>>
>>> On 11/15/2025 12:18 AM, Rob Herring wrote:
>>>> On Fri, Nov 14, 2025 at 10:06 AM Rob Herring (Arm) <robh@...nel.org> wrote:
>>>>>
>>>>>
>>>>> On Thu, 13 Nov 2025 18:35:19 +0530, Wei Deng wrote:
>>>>>> There's a WCN6855 WiFi/Bluetooth module on an M.2 card. To make
>>>>>> Bluetooth work, we need to define the necessary device tree nodes,
>>>>>> including UART configuration and power supplies.
>>>>>>
>>>>>> Since there is no standard M.2 binding in the device tree at present,
>>>>>> the PMU is described using dedicated PMU nodes to represent the
>>>>>> internal regulators required by the module.
>>>>>>
>>>>>> The module provides a 3.3V supply, which originates from the
>>>>>> main board’s 12V rail. To represent this power hierarchy in the device
>>>>>> tree, add a fixed 12V regulator node as the DC-IN source and link it
>>>>>> to the 3.3V regulator node.
>>>>>>
>>>>>> Signed-off-by: Wei Deng <wei.deng@....qualcomm.com>
>>>>>> ---
>>>>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 99 +++++++++++++++++++++++++
>>>>>>  1 file changed, 99 insertions(+)
>>>>>>
>>>>>
>>>>>
>>>>> My bot found new DTB warnings on the .dts files added or changed in this
>>>>> series.
>>>>>
>>>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>>>> are fixed by another series. Ultimately, it is up to the platform
>>>>> maintainer whether these warnings are acceptable or not. No need to reply
>>>>> unless the platform maintainer has comments.
>>>>>
>>>>> If you already ran DT checks and didn't see these error(s), then
>>>>> make sure dt-schema is up to date:
>>>>>
>>>>>   pip3 install dtschema --upgrade
>>>>>
>>>>>
>>>>> This patch series was applied (using b4) to base:
>>>>>  Base: attempting to guess base-commit...
>>>>>  Base: tags/next-20251112 (exact match)
>>>>>  Base: tags/next-20251112 (use --merge-base to override)
>>>>>
>>>>> If this is not the correct base, please add 'base-commit' tag
>>>>> (or use b4 which does this automatically)
>>>>>
>>>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20251113130519.2647081-1-wei.deng@....qualcomm.com:
>>>>>
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcielp3-supply', 'vddpcielp9-supply' do not match any of the regexes: '^pinctrl-[0-9]+$'
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p3-supply' is a required property
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>> arch/arm64/boot/dts/qcom/monaco-evk.dtb: wcn6855-pmu (qcom,wcn6855-pmu): 'vddpcie1p9-supply' is a required property
>>>>>         from schema $id: http://devicetree.org/schemas/regulator/qcom,qca6390-pmu.yaml
>>>>
>>>> This is the 3rd report of your typos. Is there some reason you are
>>>> ignoring the reports?
>>>>
>>>
>>> Sorry for the delayed response. These warnings are worth addressing 
>>> and will be resolved in the next patch.
>>>
>>
>>
>> Three of your patchsets have bugs easily pointed out by tools, so please
>> answer - are you ignoring the reports? Are you doing any tests before
>> sending?
>>
> 
> Testing was completed on the local hardware platform with successful 
> compilation and normal functionality, so the tests in this section 

Which is not enough.

Did you read kernel writing-schema guide? Or any other guide like your
own internal guideline which asks you explicitly for other tests?


> were omitted. Prior to the next submission, a dt-binding constraint 
> check will be performed.

You need to read internal guideline go/upstream before you post next
patches.

How many other tests you did not run?

Best regards,
Krzysztof