linux-kernel - Re: [PATCH v3] mmc: pxamci: Simplify pxamci_probe() error handling using devm APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251118142317.12921-1-rakuram.e96@gmail.com>
Date: Tue, 18 Nov 2025 19:53:11 +0530
From: Rakuram Eswaran <rakuram.e96@...il.com>
To: ulf.hansson@...aro.org,
	u.kleine-koenig@...libre.com
Cc: chenhuacai@...nel.org,
	dan.carpenter@...aro.org,
	david.hunter.linux@...il.com,
	khalid@...nel.org,
	linux-kernel-mentees@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	lkp@...el.com,
	rakuram.e96@...il.com,
	skhan@...uxfoundation.org,
	zhoubinbin@...ngson.cn
Subject: Re: [PATCH v3] mmc: pxamci: Simplify pxamci_probe() error handling using devm APIs

On Tue, 11 Nov 2025 at 23:06, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Thu, 23 Oct 2025 at 16:54, Rakuram Eswaran <rakuram.e96@...il.com> wrote:
> >
> > This patch refactors pxamci_probe() to use devm-managed resource
> > allocation (e.g. devm_dma_request_chan) and dev_err_probe() for
> > improved readability and automatic cleanup on probe failure.
> >
> > It also removes redundant NULL assignments and manual resource release
> > logic from pxamci_probe(), and eliminates the corresponding release
> > calls from pxamci_remove().
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Closes: https://lore.kernel.org/r/202510041841.pRlunIfl-lkp@intel.com/
> > Fixes: 58c40f3faf742c ("mmc: pxamci: Use devm_mmc_alloc_host() helper")
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> > Signed-off-by: Rakuram Eswaran <rakuram.e96@...il.com>
>
> Applied for fixes, thanks!
>
> Kind regards
> Uffe
>

Hi Ulf Hansson,

Thank you for applying to fixes branch.

Hi Uwe,

Shall I start to send the patch to remove the redundant if condition
check from pxamic_remove() function?

Link to prior discussion:
https://lore.kernel.org/linux-mmc/pvid2ycmgbkbmegnnzwl4hyev6e2smusxk5olkuqxfwxzykz2e@jlvolirolrxl/

I can pull Uffe fixes branch to send the above patch? Any inputs will be
really helpful to start working on this.

Another point, I would like to ask is about the below discussion. You have
mentioned about WIP suggestion for clk_get_rate(). 

Link to that discussion:
https://lore.kernel.org/linux-mmc/20251020183209.11040-1-rakuram.e96@gmail.com/

Was my understanding is correct?

Best Regards,
Rakuram